DanielLeens commented on PR #12165: URL: https://github.com/apache/seatunnel/pull/12165#issuecomment-6338462289
Thanks @SEZ9 and @Vivek1106-04. There is now an actionable change to the prerequisite we were waiting on: #12896 merged into dev at `99ea16b9d6bdce452d4c4955581ccc7236a81bbd` on October 22 at 06:05 UTC. Please incorporate that baseline when ready and post the fresh scheduling benchmark numbers, the candidate/baseline SHAs and CI link. I will treat the resulting new head as a full re-review trigger; no code update has happened in this exchange. The existing fork Build is failed in `SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck`. The distinct cancellation fix #12311 remains open, so incorporating the benchmark warm-up fix does not by itself establish a cure for that failed lane. Please keep the benchmark and cancellation signals separate. I have not run or dispatched benchmarks, and the remaining benchmark/CI gates are not yet satisfied. Current status evidence: head `c773cc09199ba68fb4a2a9774a0f97699f882476`, base `dev`, compare `diverged` (ahead 8, behind 231), mergeable state `blocked`. CI references: [current Build check](https://github.com/apache/seatunnel/runs/109037353609), [Run / engine-v2-it (8, ubuntu-latest)](https://github.com/Vivek1106-04/seatunnel/actions/runs/35729456152/job/107496333940). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
