SEZ9 commented on PR #12165:
URL: https://github.com/apache/seatunnel/pull/12165#issuecomment-6538929068

   Thanks @Vivek1106-04 for tracing the runner shutdown and the job time limit 
on the two non-green jobs in run 
[40463705801](https://github.com/Vivek1106-04/seatunnel/actions/runs/40463705801)
 on `a932e27a7`, and for filing the follow-up issue for the deferred 
generation-owner work. I have not inspected those job logs myself, but the 
re-run on head `a932e27a757519fe74a26cb2920966cad853aead` is green: [Signal 
pull request 
update](https://github.com/apache/seatunnel/actions/runs/40463709659/job/122617757074)
 and [Build](https://github.com/apache/seatunnel/runs/122968422970) are both 
`SUCCESS`, so the earlier failed/cancelled-job guidance is superseded.
   
   Keeping the owner-checked `handleCoordinatorError` overload, the 
package-private `expireCheckpoint` change, and the savepoint-poll interaction 
test in a separate PR opened after this one merges sounds right. No further 
source changes are needed in this PR for the reviewed scope.
   
   One remaining item: GitHub reports the branch as `diverged` from `dev` 
(ahead 15 / behind 64) with mergeable state `dirty`, i.e. real merge conflicts. 
Please sync the latest `dev`, resolve the conflicts, and push the resulting 
head so CI can run on it. Once that head is green I will re-check it; final 
approval rests with a write-capable maintainer.
   
   <!-- streview-comment:2172 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to