1328837476-hug commented on code in PR #12907: URL: https://github.com/apache/seatunnel/pull/12907#discussion_r4391188118
########## seatunnel-e2e/seatunnel-connector-v2-e2e/connector-jdbc-e2e/connector-jdbc-e2e-part-7/src/test/resources/jdbc_ingres_source_to_assert.conf: ########## @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +env { + parallelism = 1 + job.mode = "BATCH" +} +source { + Jdbc { + driver = "com.ingres.jdbc.IngresDriver" + } +} +sink { + Assert { + rules { + row_rules = [ + { rule_type = MIN_ROW, rule_value = 1 }, + { rule_type = MAX_ROW, rule_value = 1 } + ] + field_rules = [ + { field_name = "id", field_type = int, field_value = [{ rule_type = MIN, rule_value = ${ingres_expected_id} }, { rule_type = MAX, rule_value = ${ingres_expected_id} }] }, + { field_name = "Order", field_type = string, field_value = [{ rule_type = ${ingres_string_rule}, equals_to = "quoted column" }] }, + { field_name = "amount", field_type = "decimal(10,2)", field_value = [{ rule_type = MIN, rule_value = 14.25 }, { rule_type = MAX, rule_value = 14.25 }] } + ] + } + } +} +include "/tmp/ingres-jdbc-connection.conf" Review Comment: Thanks for pointing this out. Removed the include in baa9accfd. The test now resolves its own template into a complete JSON job for each row and submits that single file. Connection values still come from the environment, and the generated file is copied with mode 0600 and removed in a finally block. I also added two offline regression cases for the full configuration, assertions and password escaping. All 33 focused tests and the 68-module reactor verify pass locally. The real-Ingres run is still pending a licensed instance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
