DanielLeens commented on PR #12907: URL: https://github.com/apache/seatunnel/pull/12907#issuecomment-6397815478
Thanks for the contribution. The CI/merge fact in my previous review has changed. The exact-head [fork Build](https://github.com/1328837476-hug/seatunnel/actions/runs/40073794169) is now **completed with failure** for `c2b8d3409ed28de45551877e2448ca19176e60f9`. This is a gate correction, not a second full source review of that unchanged head. The previously listed failed jobs remain red: `unit-test (17, ubuntu-latest)` hit the Oracle test image-pull stall, and `Dead links` hit the Actian evaluation URL. My earlier review already documented the inspected Oracle log and passing Ingres/loader tests; I am not claiming a new source defect or a newly inspected log here. There is also a new merge fact: GitHub now reports **DIRTY / merge conflicts**, replacing my earlier statement that the branch was level and conflict-free. Please sync latest dev and resolve those conflicts first, preserving the Ingres change and newer upstream edits. Then rerun the failed required job on that new head once Docker image pulls are available. No matching Oracle image-pull fix was identified in latest dev, so conflict resolution is the reason to sync, not a promise to cure a registry stall. The Actian URL remains the previously recorded non-blocking documentation suggestion. Comparison against dev is `diverged`, ahead 6 / behind 8; merge conflicts: yes. The existing conflict-resolution requirement remains independent of the CI diagnosis. No new source-level blocker from my previous full review is asserted here; a successful required Build and write-capable maintainer approval remain separate gates. Daniel has READ permission, so this comment is not an effective approval. Thanks for keeping the fix focused. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
