1328837476-hug commented on PR #12907: URL: https://github.com/apache/seatunnel/pull/12907#issuecomment-6288314584
Thanks for the detailed review. I've addressed the documentation and scope points in 90c32948: - Added en/zh upgrade notes covering automatic dialect selection, quoting, exact stored case, owner.table paths, and the explicit Generic migration option. - Clarified on both source and sink pages that this is a source-first slice. The shared dialect does affect sink SQL, but sink execution and placeholder routing remain unvalidated, so the separate Ingres sink gap should stay open. - Added Ingres to all four dialect-name tables, documented the non-obvious overrides, and translated the validation README into English. - Added shouldAllowGenericOverrideForIngresMigration to verify the documented migration option. The focused suite now passes all 28 cases, and formatting checks pass. No runtime behavior changed in this follow-up. The previous Build has finished red, as you noted. #12875 is still open, so I haven't pulled that unrelated fix into this PR. Once it lands, the branch can be synced and the remaining failed checks rerun. A new build has been triggered by this push. Real-server validation remains open. I've requested an evaluation license from Actian; I don't yet have a licensed instance or a live-test result to report. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
