SEZ9 commented on issue #12918: URL: https://github.com/apache/seatunnel/issues/12918#issuecomment-6355856751
@Nikk8091 thanks for the follow-up PR at `b659ea3f` and for the clear write-up. The shape matches what was agreed here: decoding centralized in `BaseServlet.requestBody` (as inspected at `1ce2d7815665`), UTF-8 when no charset is declared, supported explicit charsets preserved, unsupported declarations rejected with a clear 400, the shared-reader consumers audited, REST documentation updated, and the query/form-body-order fix kept out. Before review, two things remain: 1. You noted the two-node `RestApiIT` attempt stopped in its existing file-sink setup before the new assertions ran. Please get that integration coverage to actually execute (on an environment where the Hadoop utilities are available, or via CI on the PR head) so the non-ASCII HOCON/SQL/JSON cases with and without an explicit charset are verified end to end, not only in the local Jetty tests. 2. Since full-repository verification is not being reported as green, please wait for head-specific CI on `b659ea3f` and note the outcome in the PR once it has run, keeping the record of commands and limitations current. Ping here or on the PR once the integration validation has run and I'll pick up the review. <!-- streview-comment:1961 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
