sudeephazra commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6347979709
Latest commit with the fixes as advised a02d87a6b18473e304e679a67127e9947ac80807 and the GHA https://github.com/sudeephazra/seatunnel-adls-connector-v2/actions/runs/39829657690 Issue | Status | Fix locations -- | -- | -- 1 | Fixed | Runtime uses `${project.version}` for connector-file-base: [pom.xml:52](seatunnel-adls-connector-v2/seatunnel-connectors-v2/connector-file/connector-file-adls-runtime/pom.xml:52). 2 | Fixed | Hadoop uber, Shade, and Surefire inherit parent management. Restored the required Azure version because its dependency is not parent-managed: [pom.xml:30](seatunnel-adls-connector-v2/seatunnel-connectors-v2/connector-file/connector-file-adls-runtime/pom.xml:30), [Shade declaration:60](seatunnel-adls-connector-v2/seatunnel-connectors-v2/connector-file/connector-file-adls-runtime/pom.xml:60). 3 | Fixed | Added trust-boundary wording to [ADLSFileBaseOptions.java:84](seatunnel-adls-connector-v2/seatunnel-connectors-v2/connector-file/connector-file-adls/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSFileBaseOptions.java:84) and all four references: [EN source:117](seatunnel-adls-connector-v2/docs/en/connectors/source/ADLSFile.md:117), [EN sink:111](seatunnel-adls-connector-v2/docs/en/connectors/sink/ADLSFile.md:111), [ZH source:101](seatunnel-adls-connector-v2/docs/zh/connectors/source/ADLSFile.md:101), [ZH sink:96](seatunnel-adls-connector-v2/docs/zh/connectors/sink/ADLSFile.md:96). 4 | Fixed | Updated description. 5 | Fixed | Removed setSchema near [ADLSHadoopConf.java:48](seatunnel-adls-connector-v2/seatunnel-connectors-v2/connector-file/connector-file-adls/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSHadoopConf.java:48). Made test helpers package-private starting at [ADLSRuntimeCompatibility.java:58](seatunnel-adls-connector-v2/seatunnel-connectors-v2/connector-file/connector-file-adls-runtime/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/config/ADLSRuntimeCompatibility.java:58); updated cloud-test setup accordingly. 6 | Fixed | Appended ADLS after SMB in [FileSystemType.java:34](seatunnel-adls-connector-v2/seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/FileSystemType.java:34), removed the TODO near [ADLSFileCatalog.java:24](seatunnel-adls-connector-v2/seatunnel-connectors-v2/connector-file/connector-file-adls/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/adls/catalog/ADLSFileCatalog.java:24), and imported [Path at line 52](seatunnel-adls-connector-v2/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-adls-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/adls/AzuriteWasbFileIT.java:52). 7 | Partially addressed | Removed the empty profile and added default-CI source/sink validation jobs at [AzuriteWasbFileIT.java:165](seatunnel-adls-connector-v2/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-adls-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/adls/AzuriteWasbFileIT.java:165). Successful ABFS storage I/O still requires a dedicated Azure test account; the cloud round trip remains [opt-in:65](seatunnel-adls-connector-v2/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-adls-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/adls/ADLSFileIT.java:65). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
