SEZ9 commented on PR #12293: URL: https://github.com/apache/seatunnel/pull/12293#issuecomment-6228945187
Thanks for keeping the branch in sync with dev. Comparing head `468944c851` with `781ba2ec3d`, the only change is the merge of `apache:dev`, and none of the ADLS connector, runtime, E2E or doc files changed in between, so I have no new findings on the connector code itself. The one item that does need attention at this head is the hard-coded version in `connector-file-adls-runtime/pom.xml`, which became wrong once dev moved to `3.0.1-SNAPSHOT`. Could you switch it to the project revision so the module builds against current dev? Separately, could you point me to where the earlier points were handled (or let me know if any are still open)? A short pointer per item is enough: - F1 – validator trims option values while `ADLSHadoopConf` consumes the raw values. - F2 – sink docs should state the HNS (hierarchical namespace) requirement for the atomic `tmp_path` -> `path` rename. - F3 – validation rules (account_name/container naming, auth mutual exclusion, blocked `hadoop_adls_properties` keys) undocumented, and the shipped template placeholders violate them. - F4 – OAuth token endpoint built from unvalidated `authority_host` / `tenant_id` (HTTPS and host validation). - F5 – option tables missing factory-exposed options and en/zh sink tables drifted. - F6 – `ConfigShadeUtils` change adding `account_key` to the default log-mask list not mentioned in docs or PR description. - F7 – English source doc defaults for `discovery_mode` / `start_mode` vs code defaults `ONCE` / `EARLIEST`. - F8 – `hadoop_adls_properties` prefix denylist still allowing class-loading and token-provider ABFS keys. Once the POM version is fixed I am happy to do a final pass. <!-- streview-comment:1818 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
