DanielLeens commented on PR #10961:
URL: https://github.com/apache/seatunnel/pull/10961#issuecomment-6286245726
Pushed two commits on top of this branch, @PZh101 (I had pushed the previous
`dev` merge here in July, so the maintainer-edit path is still open):
1. Merge of the current `dev`. The only conflict was the `JdbcInputFormat`
constructor, where `dev` split it into a delegating constructor; resolved by
keeping `dev`'s shape and this PR's extra `JdbcConnectionConfig` argument to
`JdbcDialectLoader.load(...)`.
2. The two blockers from my 2026-08-07 review:
- `KingbaseCatalogFactory.detectCompatibleMode` now returns an explicitly
configured `compatible_mode` and only live-probes the connection when it is
absent, mirroring `KingbaseDialectFactory`; the fallback log is now WARN with
the same wording as the dialect factory, and `compatible_mode` is declared as
an optional option on the catalog rule. New `KingbaseCatalogFactoryTest`
(unroutable URL, so a probe would fail) asserts `mysql` selects `MySqlCatalog`
and `pg` selects `KingbaseCatalog`.
- `KingbaseDialect.getUpsertStatement` MySQL branch now builds `new
MysqlDialect(fieldIde)`;
`KingbaseDialectTest.testMySQLCompatibleUpsertStatementKeepsFieldIde` asserts
that `field_ide = UPPERCASE` reaches the generated statement.
The double-connection-on-factory-creation and silent-fallback points from
the earlier thread are reduced to the no-`compatible_mode` path only. Only
`spotless` was run locally; your fork did not create a Build run for this push,
so please start one from the Actions tab if none appears. Verification run of
the same head on my fork:
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr10961-verify-f1053980882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
