DanielLeens commented on PR #11669: URL: https://github.com/apache/seatunnel/pull/11669#issuecomment-6286527571
Pushed `0f1d6396e69` on top of your branch, @waterWang (merge of the current `dev` plus one commit) to close Issue 1 from the reviews: - `YamlSeaTunnelDomConfigProcessor.parseHttpConfig` now has a `public-url` branch that calls `httpConfig.setPublicUrl(...)` (the setter comes from `@Data` on `HttpConfig`), so the option is no longer dropped as an unrecognized element and `LogService` actually sees it. - The parser test fixture `seatunnel.yaml` sets `public-url: https://seatunnel.example.com/zeta` and `YamlSeaTunnelConfigParserTest` asserts the parsed value, so the wiring cannot regress silently; this assertion fails on the previous head. - The merge conflict in `HttpConfig.java` (your `publicUrl` field vs the new upload/log size fields on `dev`) is resolved by keeping both. Your fork did not create a Build run for this push; if none appears, please start one from the Actions tab ("Run workflow" on Build). I started a verification run of the same head on my fork: https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr11669-verify-0f1d6396e69 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
