DanielLeens commented on PR #11838:
URL: https://github.com/apache/seatunnel/pull/11838#issuecomment-6286123683

   Pushed `394c5b2f028` on top of your branch, @RaphaelAdewale, for Issue 5 
from my last review: `SplunkIT` now gives the Splunk container a single 
30-minute startup attempt (`STARTUP_TIMEOUT`) for both the container and the 
HEC health wait strategy, instead of two 10-minute attempts that each restarted 
first-boot provisioning from scratch. Test-only; no sink code changed.
   
   Two things I could not do from my side:
   - The branch is in conflict with `dev` in `seatunnel-connectors-v2/pom.xml`, 
`seatunnel-e2e/seatunnel-connector-v2-e2e/pom.xml`, 
`plugin-mapping.properties`, `config/plugin_config` and 
`.github/workflows/labeler/label-scope-conf.yml` (new connectors registered on 
`dev` next to yours). These are registration-list conflicts that keep both 
entries; please merge `dev` and resolve them on your side, since the `pom.xml` 
files are something I do not change on a contributor branch.
   - Your fork did not create a Build run for this push; the last run is still 
the one with the two startup timeouts. I started a verification run of this 
head on my fork: 
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr11838-verify-394c5b2f028


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to