DanielLeens commented on PR #11398:
URL: https://github.com/apache/seatunnel/pull/11398#issuecomment-6285844698

   Pushed `dbd0a75fd6d` on top of your branch, @Isha2790 (merge of the current 
`dev` plus one commit) to close the three open items:
   
   1. Vertex-id gap: `inputVertexId` / `targetVertexId` go through a small 
`toStringOrNull` helper, so a null id renders as JSON null instead of throwing.
   2. Broader coverage: `jobId` (JSON null when absent), `envOptions` (empty 
object when absent) and `vertexInfoMap` (empty array when absent) are guarded 
the same way; inside each `VertexInfo`, a null entry is skipped and a null 
`type` / `tablePaths` no longer fails. The method now has a Javadoc stating 
this contract.
   3. Tests: new `JobDAGInfoTest` in `seatunnel-engine-core` covers the 
all-null no-arg instance, an edge with a null vertex id (plus a null edge in 
the list), and partial `VertexInfo` entries; each case fails on the previous 
head with a `NullPointerException`.
   
   The PR description should be updated to match this scope (all fields of 
`JobDAGInfo`, not only `pipelineEdges`). Your fork has not produced a Build run 
yet; please enable GitHub Actions on it if needed and start the Build workflow 
from the Actions tab. I started a verification run of the same head on my fork: 
https://github.com/DanielLeens/seatunnel/actions?query=branch%3Apr11398-verify-dbd0a75fd6d


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to