DanielLeens commented on PR #11398: URL: https://github.com/apache/seatunnel/pull/11398#issuecomment-6338512806
Thanks @SEZ9 for spelling out the consumer-side concern. I treated that contract too lightly in my earlier review; sorry for that. I checked the actual UI path on unchanged head `db2197412815` and agree with your existing F1 rather than adding a duplicate finding: `JobDAGInfo.toJsonObject` (65-69) emits an edge even when one endpoint is null. The DAG renderer at `seatunnel-engine-ui/src/components/directed-acyclic-graph/index.tsx:426-445` unconditionally constructs cells such as `node-null`, and converts the endpoint with Number(...); it does not filter that edge before constructing it. The logical-DAG packaging path also acknowledges a possible null input at `DAGUtils.java:169-172`. Rendering JSON successfully is therefore not enough to establish that the UI can consume the new value safely. +1 to your F1 request to drop an edge with an absent endpoint and retain diagnostic context. The observability requests F2/F3 overlap my earlier note about silently substituted structural nulls; logging should explain the job/pipeline and degradation without claiming a partially written IMap value is a demonstrated cause. Please handle that alongside the null-endpoint regression case. The order-independent vertex assertions from your F6 are also the right way to avoid a HashMap-order assumption. I am withdrawing the earlier "CI-only" characterization: the existing consumer-contract request is not cleared. This is a response to your existing findings, not a fresh full review or a new batch of numbered findings. Build also remains failed; the LLM fixture correction #12938 and template-provider proposal #12895 are still open, so current-dev sync alone is not a demonstrated cure for those failures. Please push the focused fix and then I will re-review the full updated diff. Final approval still belongs to a write-capable maintainer. Current status evidence: head `db2197412815492a756914021cb8157a0bc694cd`, base `dev`, compare `diverged` (ahead 4, behind 8), mergeable state `blocked`. CI references: [current Build check](https://github.com/apache/seatunnel/runs/119198636589), [Run / transform-v2-it-part-2 (11, ubuntu-latest)](https://github.com/Isha2790/seatunnel/actions/runs/39573285512/job/119133706428), [Run / mysql-cdc-connector-it (11, ubuntu-latest)](https://github.com/Isha2790/seatunnel/actions/runs/39573285512/job/119133707350). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
