DanielLeens commented on PR #11478:
URL: https://github.com/apache/seatunnel/pull/11478#issuecomment-6285764914

   Status update while going through the open first-time-contributor PRs, 
@muyuQvQ: I tried to sync this branch with `dev` to clear the merge conflict 
and found that the same fix has since landed on `dev` through #11562 
(`74905675806`, "Wait for Doris data visibility"). `DorisCommitInfo` on `dev` 
already carries the `label` field with a symmetric serializer, and the 
committer already waits for the transaction to become visible, which is what 
this PR set out to do. All four conflicting files (`DorisCommitInfo`, 
`DorisCommitInfoSerializer`, `DorisCommitter`, `DorisSinkWriter`) resolve to 
the `dev` versions with nothing left from this branch, so I did not push 
anything here.
   
   If you see a case that #11562 does not cover, please describe it and we can 
look at a follow-up; otherwise this PR can be closed as superseded (a committer 
call). Thanks for the original diagnosis in #11433.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to