fatmanverse commented on issue #12874: URL: https://github.com/apache/seatunnel/issues/12874#issuecomment-6285834488
Thanks @hutiefang76 for reporting this and for #12875. I hit the same failure on my PRs and have an alternative fix on a branch, posting it here so maintainers can choose the scope they prefer. The completeness test expects the sink to declare `numeric_special_value_as_null` because the option was defined in `JdbcCommonOptions`, which the sink options inherit. Since #12792 only reads it on the source side, another way is to define it where it applies: - move `NUMERIC_SPECIAL_VALUE_AS_NULL` from `JdbcCommonOptions` to `JdbcSourceOptions` (key, type, default and description unchanged), and update the three references in `JdbcConnectionConfig`; - `JdbcOptionRuleCompletenessTest` then passes without an exclusion, and a `JdbcSinkFactoryTest` case checks that the sink still rejects the key. Branch: https://github.com/fatmanverse/seatunnel/compare/dev...move-numeric-special-option-to-source (4 files, +27/-10). Verified on JDK 17: the `connector-jdbc` unit tests pass (1154 tests, 0 failures, 6 skipped). The option was added in #12792 and has not been released yet, so moving it does not affect users. Either fix makes `dev` green. If maintainers prefer this one, I can open a PR (or @hutiefang76 is welcome to take it into #12875); otherwise #12875 is fine with me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
