SEZ9 commented on issue #12874: URL: https://github.com/apache/seatunnel/issues/12874#issuecomment-6258858178
Thanks for the clear report and reproduction. Since numeric_special_value_as_null is documented as a PostgreSQL source-only read option, excluding it from the sink completeness check (mirroring the existing SCHEMA source-side exclusion) sounds like the right approach — please open the PR and link #12792. In the PR, consider making the exclusion list a named constant (e.g. SOURCE_ONLY_OPTIONS / SINK_ONLY_OPTIONS) with a comment pointing to the docs, so future source-only options added to JdbcCommonOptions do not break the sink test the same way. Could you confirm whether the reflected JdbcCommonOptions field could instead live in a source-specific options class (e.g. JdbcSourceOptions)? If so, moving it there may be a cleaner long-term fix than an exclusion list, though a test-only correction is fine to unblock dev CI. <!-- streview-comment:1864 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
