fatmanverse commented on PR #12875: URL: https://github.com/apache/seatunnel/pull/12875#issuecomment-6262169606
Thanks for catching this. I added `JdbcOptionRuleCompletenessTest` in #12800, and I can confirm the failure: on `dev` (e2957d2) the full `connector-jdbc` unit tests have exactly one failure, `testSinkRuleDeclaresAllSinkOptions` (`unknown option keys: [numeric_special_value_as_null]`), on JDK 17. The fix here looks right to me. `NUMERIC_SPECIAL_VALUE_AS_NULL` is documented as a PostgreSQL source read option and only the source factory declares it, so excluding it from the sink coverage is the intended scoping, the same way `schema` is excluded on the source side. The new `testSourceOnlyOptionRejectedBySinkRule` also keeps the source/sink split from drifting silently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
