hutiefang76 opened a new pull request, #12875:
URL: https://github.com/apache/seatunnel/pull/12875
### Purpose of this pull request
The sink completeness test reflects inherited options and currently expects
the source-only `numeric_special_value_as_null` key added in #12792 to be
accepted by the sink. This makes clean dev fail even though the production
source/sink rules match the documented scope.
Exclude this key from sink completeness coverage, mirroring the existing
source-side scoped exclusion. Add a guard using the actual factories to keep
the key accepted by the source and rejected by the sink. Every other inherited
sink option remains covered.
Fixes #12874. Yes, I am contributing this test fix to Apache SeaTunnel.
### Does this PR introduce _any_ user-facing change?
No. Only the existing test class changes. Production option rules, defaults
and parsing behavior are unchanged.
### How was this patch tested?
Clean baseline: `JdbcOptionRuleCompletenessTest` reports two tests with one
failure. After the fix:
- Full JDBC package run: **1,154 JDBC tests, zero failures/errors, six
conditional skips**; required reactor dependencies also pass.
- Final focused class: three tests pass, no skips. Repeated after removing
redundant value iterations because this validator checks keys only.
- Root `./mvnw -q -DskipTests verify` passes (root verification skips test
execution).
- Spotless and independent full-diff review pass. JDK 17.0.18.
```sh
./mvnw -pl seatunnel-connectors-v2/connector-jdbc -am package
./mvnw -pl seatunnel-connectors-v2/connector-jdbc -am \
-Dtest=JdbcOptionRuleCompletenessTest \
-Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false package
./mvnw -q -DskipTests verify
```
### Check list
* [ ] New JAR license notice: not applicable; no dependency changes.
* [ ] User documentation: not applicable; test-only correction.
* [ ] Incompatible changes: not applicable.
* [ ] Connector registration/E2E/config files: not applicable; no connector
runtime code changes.
<sub>Implemented, tested, independently reviewed and posted with AI
assistance for @hutiefang76.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
