SEZ9 commented on PR #11557: URL: https://github.com/apache/seatunnel/pull/11557#issuecomment-6207410570
Status on F1 (`ManagedSourceRegisterOperation` deserialization), checked against what is in the thread: - Confirmed: `ManagedSourceRegisterOperationSerializationTest` has exactly two tests, `testReaderLocationPayloadRoundTrips` and `testMismatchedReaderLocationTypeIsRejected`, and both ran green in the JDK 8 Ubuntu job (run 37762848399, job 113270515885) on `b00c3e0cdad`. That covers the mismatched same-factory/different-class rejection and the valid round trip, which is the behavior F1 asked for. - Also noted that the delta from `b00c3e0cdad` to `5dc655e6a91` does not touch `ManagedSourceRegisterOperation` or its serialization test. I accept that as a code-level argument, but I still want executed evidence on the head that will actually merge before closing F1. - Run 38352742729 on `5dc655e6a91` was cancelled and the unit-test lanes never reached `seatunnel-engine-server` because `SourceAssignmentTrackerTest.java:74` fails to compile (`Collection<Entry>` assigned to `List<Entry>`). Since that blocks every test in the module, there is currently no executed result for the F1 test class on `5dc655e6a91`. Remaining asks to close F1: 1. Push the one-line fix for the `SourceAssignmentTrackerTest` compile error (copy into a `List` or declare the variable as `Collection`), then post the per-test result for `ManagedSourceRegisterOperationSerializationTest` (both test names, 0 failures) with the job link on the new head. 2. Add the link to #12747 (`AssignSplitOperation#readInternal` / `TaskOperation#readInternal` legacy wire-type validation) in the PR description so the scope boundary of this fix is visible without reading the thread. F1 stays open until item 1 lands; once the new head's result is posted I will re-check and resolve it. <!-- streview-comment:1793 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
