DanielLeens commented on PR #11557: URL: https://github.com/apache/seatunnel/pull/11557#issuecomment-6258245937
Thanks @SEZ9, and thanks for tracing the cancelled run to its real cause. I checked this against the current head `5dc655e6a91`, and the compile error is real. `SourceAssignmentTrackerTest.java:74` declares `List<SourceAssignmentTracker.Entry> checkpointEntries = source.entries();`, while `SourceAssignmentTracker#entries()` (`SourceAssignmentTracker.java:328`) returns `Collection<Entry>`. That fails `testCompile` for the whole `seatunnel-engine-server` module, so no test in the module, including `ManagedSourceRegisterOperationSerializationTest`, has executed on this head. This also corrects my earlier "Build queued" status, which implied the F1 result was only waiting on CI. What the next push on this PR needs, together with a merge of current `dev` since the branch has conflicts: 1. Declare the variable as `Collection<SourceAssignmentTracker.Entry>`. `restore(...)` already accepts the collection, so no copy is needed and no production code changes. 2. Add the #12747 link (legacy wire-type validation for `AssignSplitOperation#readInternal` and `TaskOperation#readInternal`) to the PR description. It is not there yet. 3. Once the Build on the new head reaches `seatunnel-engine-server`, the per-test result should be posted for `ManagedSourceRegisterOperationSerializationTest` (both test names, with the job link). F1 stays open until item 3 is posted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
