DanielLeens commented on PR #12218: URL: https://github.com/apache/seatunnel/pull/12218#issuecomment-6181400078
Thanks @Rangsh for reading both logs yourself, that saves everyone time. I cross-checked them on fork run 38496659794 (head `35f5a2fcf7c`), and your reading holds: - `engine-v2-it (11)` is the same `SplitClusterFaultToleranceIT.testStreamJobCancelResolvesWhenWorkerCrashesBeforeCancelAck` cancel-vs-worker-loss race from my last note. #12311 is still open and not on `dev`, so a sync will not clear it, and nothing in this diff touches that path. - `kafka-connector-it (17)` fails only on the Testcontainers image build (`received unexpected HTTP status: 500 Internal Server Error`), before any Kafka test logic runs. That is a registry/runner flake, not related to this PR. My conclusion is unchanged: no source blocker on the three PR-owned files, and the head has not moved since my last review, so this is not a new re-review. The remaining gates are the CI items above (the Kafka one should clear on any fresh run) and the committer approval; as a read-only reviewer I cannot do the formal approval. One small practical note: the branch is now 13 commits behind `dev`, so whenever you next sync, that push will also give you a fresh fork run for the Kafka lane. Thanks again for the patient iterations! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
