Rangsh commented on PR #12218:
URL: https://github.com/apache/seatunnel/pull/12218#issuecomment-6145546733
Thanks @DanielLeens for the careful re-review, and for tracing this down to
the exact line. The pre-publication regression was mine, and your diagnosis was
exactly right: the shared `catch` made the pre-publication branch complete with
a FAILED state instead of exceptionally, so the `Task <loc> complete with error
<msg>` severe log was never written and
`TaskDeploymentPrePublicationClassLoaderLeakIT` failed at line 425.
Both points are now addressed:
1. **Issue 1 fixed on `d1f6796a`.** The `catch` is split on
`contextPublished`:
- post-publish: `rollbackPublishedDeployment(...)`, then
`resultFuture.complete(new TaskExecutionState(loc, FAILED, t))`, so a FAILED
already completed by `taskDone` is preserved;
- pre-publication: `onFailureBeforeContextPublished.accept(t)`, then
`resultFuture.completeExceptionally(t)`. This restores the previous completion
and logging contract for that branch, which now matches `dev` again.
2. **`dev` synced.** Merged latest `upstream/dev` (`b0f6feddf`) in
`154d6e989` with no conflicts. The branch is now up to date with `dev` (ahead
10, behind 0).
Locally `TaskExecutionServiceTest` is green (27 tests) and spotless has been
applied. The fork `Build` run for the merged head is in progress now
(`38396665202`); I will post the `engine-v2-it` /
`TaskDeploymentPrePublicationClassLoaderLeakIT` results as soon as they
complete. I also noticed the two `elasticsearch-connector-it` failures — as you
said, this PR touches no Elasticsearch code, so I'll treat them as unrelated
unless they show up again.
@SEZ9, when you have a moment, would you mind approving and running the
workflows on this head? Thank you both for the patient rounds on this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
