Rangsh commented on PR #12218: URL: https://github.com/apache/seatunnel/pull/12218#issuecomment-6125398219
Thanks @DanielLeens for the careful re-review, and for spelling out both Low items so clearly. Both are addressed on `d03ef1ba6`: 1. **Worker rollback guards now use the tracker's own context.** `BlockingWorker` and `CooperativeTaskWorker` no longer call `executionContexts.get(taskGroupLocation)`. They read `TaskGroupExecutionTracker.context`, so a later deployment at the same location cannot hide this generation's rollback signal (a null classloader map). An ordinary cancel still runs `init()` / `call()` / `close()`. 2. **The two tests are tightened.** `releaseClassLoadersOnce` is now package-visible, in the same style as `blockingTaskExecutorOverride`, and `testRecycleClassLoaderAfterRollbackClaimDoesNotDoubleRelease` calls it directly instead of reflecting on the private name. `testTaskGroupContextClassLoaderReleaseClaimIsAtomic` now races two threads on one context with a `CyclicBarrier` and asserts exactly one non-null claim, so removing the CAS would no longer leave the test green. `TaskExecutionServiceTest` is green locally (27 tests). This is still a fork PR, so I cannot approve the workflow myself. @SEZ9, when you have a moment, could you please approve and run the workflows on this head? Thank you both. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
