SEZ9 commented on PR #11677: URL: https://github.com/apache/seatunnel/pull/11677#issuecomment-6159485179
Thanks @li3zhi4 for the pointer list on `c959fd1989`. I haven't yet checked those ranges against the diff myself, so I'll hold off on marking anything resolved until I've read them. Concretely, I'll go through `mysqlcdc_to_mysql_with_sink_failure_recovery.conf:18-27` for the retry headroom, `SourceSplitEnumerator.java:41-58` and `SourceSplitEnumeratorTask.java:241-247` for the contract/ordering wording, `IncrementalSourceEnumerator.java:74-115` plus `IncrementalSourceEnumeratorTest.java:41-82` for the pre-run path and its tests, and `AbstractMysqlCDCITBase.java:245-289` / `:305-330` for the wait budgets. One item I don't see called out in your list: the `getServerLogs().substring(logOffset)` check in `AbstractMysqlCDCITBase.java`. On `c959fd1989`, is it guarded against the server log shrinking or rotating during the restart window so that it retries inside the awaitility wait instead of throwing `StringIndexOutOfBoundsException`? If so, could you point me to the line range? Once I've been through the ranges above and that point is clarified, I'll follow up with a final review. <!-- streview-comment:1733 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
