SEZ9 commented on PR #11677: URL: https://github.com/apache/seatunnel/pull/11677#issuecomment-6136981670
Thanks @li3zhi4 for the update on the remaining item from review 5479163539 and for the pointer correction. I haven't yet looked at `bedcc58b4a` or the current head myself, so I can't mark anything resolved based on the description alone. I'll go through the diff for the reworded recovery comment, the injected-failure log wait and the two-minute budget, the log-length clamp, and the `finally` trigger removal with `retry=3`. On that last point, it would help if the intent behind `retry=3` is captured in a comment next to the setting so a future reader doesn't tighten it. For F1–F4, I'll also verify on the current head how the pre-run `addSplitsBack()` window in `IncrementalSourceEnumerator` and the `SourceSplitEnumerator` javadoc wording landed. If any of those are in a different place than I expect, a short pointer would be appreciated, but I'll base the outcome on the code rather than the thread. Agreed that the Remote Build dispatch and a write-enabled approval are separate gates and aren't satisfied by a comment-only update; I'll follow up on those after reviewing the head. <!-- streview-comment:1707 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
