TianHengZhuang commented on PR #12367: URL: https://github.com/apache/seatunnel/pull/12367#issuecomment-5902371029
Both are fair, done. **Issue 1 (valid ranges not documented)**: added a range sentence to the `bulk_size` and `max_cache_row_size` sections in both `docs/en/connectors/sink/SensorsData.md` and the zh page, so the docs now say `bulk_size` must be greater than 0 and `max_cache_row_size` must be `0` or greater, and that an out-of-range value is rejected during option validation. You also mentioned there was no note on the incompatible-changes page for the fail-fast tightening, so I added one: a `SensorsData Sink` section on the en and zh pages saying the two options had no range constraint before, that a job setting an out-of-range value now fails at job creation with `OptionValidationException` instead of starting, and that the defaults and in-range values are unaffected. Happy to drop it if you would rather keep this PR to code plus the connector pages. **Issue 2 (stale description)**: refreshed. The Change log now only lists the two range constraints, the doc updates and the four tests, and it says explicitly that `server_url` and `consumer` shipped in #12315 and are not part of this PR. The "Decision (Option A)" bullet and the stale `server_url` test line are gone. No code change in this commit, it is docs only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
