TianHengZhuang commented on PR #12367:
URL: https://github.com/apache/seatunnel/pull/12367#issuecomment-5859745202

   Applied `mvn spotless:apply -pl 
seatunnel-connectors-v2/connector-sensorsdata -am` locally and committed the 
exact output, so the trailing-blank-line violation is gone. `Build` is green on 
`2863069a` now.
   
   Re: closing this and cutting a small follow-up PR with `bulk_size` / 
`max_cache_row_size` on top of current `dev` - that works for me too. Since the 
branch is already rebased and in sync with `dev` and CI is green, my preference 
is to keep this one and land it; but if you'd rather review a clean follow-up 
instead, say the word and I'll close this and open it. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to