TianHengZhuang commented on PR #12367: URL: https://github.com/apache/seatunnel/pull/12367#issuecomment-5723258003
@DanielLeens Thank you for the thorough review. Responses and next steps: **1. Tests (blocker)** - I will add focused unit tests in `SensorsDataSDKFactoryTest` for: missing/blank `server_url`, `bulk_size <= 0`, `max_cache_row_size < 0`, and valid boundaries (`bulk_size = 1`, `max_cache_row_size = 0`). **2. `server_url` + `consumer = console`** - Choosing **Option A**: keep `server_url` unconditionally required, matching documented contract (`Required: Yes` in SensorsData docs). I will state this explicitly in the PR description as an intentional fail-fast tightening. Rationale: the docs already promise the requirement; console consumers that omit it are relying on an undeclared code path. **3. Overlap with #12315** - Happy to coordinate. Preferred outcome per your note: one PR with #12315's tests plus this PR's `bulk_size`/`max_cache_row_size` constraints. I can rebase after #12315 lands, or fold these constraints into that branch if maintainers prefer. CI `action_required` is expected for a first-time contributor workflow approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
