Vivek1106-04 commented on issue #12339:
URL: https://github.com/apache/seatunnel/issues/12339#issuecomment-5758377332

   That matches what I built, so we are aligned. `checkpointSingleInput` is
   untouched and the new benchmark is a separate class.
   
   It is open as https://github.com/apache/seatunnel/pull/12418.
   
   `CheckpointSchedulingBenchmark` samples the delay between a checkpoint 
trigger
   becoming due and its scheduling thread running it, as a distribution rather 
than
   a mean (`Mode.SampleTime`, so p50/p99/max), sweeping `pipelineNum` 1 / 10 / 
100 /
   500. That is the axis the scheduling model is on: every 
`CheckpointCoordinator`
   builds its own two-thread pool, so a member running P pipelines carries 2P
   scheduler threads, while a shared pool is a fixed width whatever P is.
   
   How long a trigger occupies its thread is a parameter (`triggerBodyMicros`)
   rather than a fixed cost, since that is what decides whether a given pool 
width
   is wide enough and it is not the same for every deployment.
   
   Your three review points on that PR are addressed and pushed: the 4g heap, 
the
   README revert, and registering the benchmark in `benchmarks.yml`.
   
   Next I run the full sweep on `dev` for the baseline, then the identical sweep
   against #12165, so the two scheduling models are compared on the same 
settings
   rather than on argument.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to