dybyte commented on code in PR #9574:
URL: https://github.com/apache/seatunnel/pull/9574#discussion_r2216318521
##########
seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/source/RedisSourceFactory.java:
##########
@@ -54,7 +54,9 @@ public OptionRule optionRule() {
RedisSourceOptions.HASH_KEY_PARSE_MODE,
RedisBaseOptions.AUTH,
RedisBaseOptions.USER,
- RedisBaseOptions.KEY)
+ RedisBaseOptions.KEY,
+ RedisSourceOptions.READ_KEY_ENABLED,
+ RedisSourceOptions.SINGLE_FIELD_NAME)
Review Comment:
I was looking at the code and noticed that the behavior of the KEY and
STRING types seems completely identical.
Is there a specific reason why the KEY type is separated out?
Was KEY perhaps introduced to semantically distinguish it from other types
that can hold multiple values?
Also, just to confirm: When key_read_enabled=true and data_type=key, should
single_field_name be mandatory?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
