dybyte commented on code in PR #9574:
URL: https://github.com/apache/seatunnel/pull/9574#discussion_r2222620880
##########
seatunnel-connectors-v2/connector-redis/src/main/java/org/apache/seatunnel/connectors/seatunnel/redis/source/RedisSourceFactory.java:
##########
@@ -54,7 +54,10 @@ public OptionRule optionRule() {
RedisSourceOptions.HASH_KEY_PARSE_MODE,
RedisBaseOptions.AUTH,
RedisBaseOptions.USER,
- RedisBaseOptions.KEY)
+ RedisBaseOptions.KEY,
+ RedisSourceOptions.READ_KEY_ENABLED,
+ RedisSourceOptions.SINGLE_FIELD_NAME,
+ RedisSourceOptions.KEY_FIELD_NAME)
Review Comment:
@liunaijie
Thank you for the suggestion!
However, I’d like to clarify that `single_field_name` is only applicable
when the value in Redis is a single value (e.g., string or int).
In other cases, setting `single_field_name` has no effect.
If we want to make a required option, I believe enforcing `key_field_name`
when `read_key_enabled=true` would be more appropriate.
What kind of constraint do you think would be appropriate to add?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
