dybyte opened a new pull request, #9574:
URL: https://github.com/apache/seatunnel/pull/9574

   Fixes https://github.com/apache/seatunnel/issues/8838
   
   ### Purpose of this pull request
   
   This PR adds a new `read_key_enabled` option to the Redis source connector, 
which when enabled, includes the Redis key in each output record along with the 
value.  
   Currently, this feature requires the schema to have a `key` field named 
exactly as such and expects JSON-formatted data.  
   Future improvements will focus on supporting flexible key field naming.
   
   ### Question
   
   As I understand, without an explicit schema, Seatunnel maps fields by order, 
making it hard to insert the Redis key reliably.  
   Currently, `read_key_enabled` requires a schema with a `key` field and JSON 
format.  
   
   Is there a recommended way to support this feature without schema?
   Thanks for your advice!
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes, this PR introduces a new configuration option read_key_enabled in the 
Redis source connector.
   When enabled, Redis keys will be included as part of the output record 
alongside the value.
   This change improves the usability of the connector in workflows that 
require access to both keys and values.
   
   ### How was this patch tested?
   
   e2e tests were conducted for multiple Redis data types including string, 
list, set, and zset.
   Additionally, tests were performed on complex data structures with custom 
keys, verifying the feature works correctly with various schema definitions and 
supports custom sink keys.
   
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [x] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the 
following files are updated:
     1. Update 
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     2. Update the pom file of 
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in 
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in 
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector 
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to