TyrantLucifer commented on code in PR #4164: URL: https://github.com/apache/incubator-seatunnel/pull/4164#discussion_r1118029769
########## seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/writer/ExcelWriteStrategy.java: ########## @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.seatunnel.connectors.seatunnel.file.sink.writer; + +import org.apache.seatunnel.api.table.type.SeaTunnelRow; +import org.apache.seatunnel.common.exception.CommonErrorCode; +import org.apache.seatunnel.connectors.seatunnel.file.exception.FileConnectorException; +import org.apache.seatunnel.connectors.seatunnel.file.sink.config.FileSinkConfig; +import org.apache.seatunnel.connectors.seatunnel.file.sink.util.ExcelGenerator; + +import org.apache.hadoop.fs.FSDataOutputStream; + +import lombok.NonNull; + +import java.io.IOException; +import java.util.HashMap; +import java.util.Map; + +public class ExcelWriteStrategy extends AbstractWriteStrategy { + private final Map<String, ExcelGenerator> beingWrittenWriter; + + public ExcelWriteStrategy(FileSinkConfig fileSinkConfig) { + super(fileSinkConfig); + this.beingWrittenWriter = new HashMap<>(); + } + + @Override + public void write(SeaTunnelRow seaTunnelRow) { + String filePath = getOrCreateFilePathBeingWritten(seaTunnelRow); + ExcelGenerator excelGenerator = getOrCreateExcelGenerator(filePath); + excelGenerator.writeData(seaTunnelRow); + } + + @Override + public void finishAndCloseFile() { + this.beingWrittenWriter.forEach( + (k, v) -> { + try { + fileSystemUtils.createFile(k); + FSDataOutputStream fileOutputStream = fileSystemUtils.getOutputStream(k); + v.flushAndCloseExcel(fileOutputStream); + fileOutputStream.close(); + } catch (IOException e) { + log.error(""); Review Comment: Remove it. ########## seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSinkConfig.java: ########## @@ -220,4 +220,16 @@ public class BaseSinkConfig { .stringType() .noDefaultValue() .withDescription("Kerberos keytab file path"); + + public static final Option<Integer> MAX_ROWS_IN_MEMORY = + Options.key("max_rows_in_memory") + .intType() + .noDefaultValue() + .withDescription("Max rows in memory"); + + public static final Option<String> SHEET_NAME = + Options.key("sheet_name") + .stringType() + .noDefaultValue() + .withDescription("To be written sheet name"); Review Comment: The same as above. ########## seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSinkConfig.java: ########## @@ -220,4 +220,16 @@ public class BaseSinkConfig { .stringType() .noDefaultValue() .withDescription("Kerberos keytab file path"); + + public static final Option<Integer> MAX_ROWS_IN_MEMORY = + Options.key("max_rows_in_memory") + .intType() + .noDefaultValue() + .withDescription("Max rows in memory"); Review Comment: ```suggestion .withDescription("Max rows in memory, only valid for excel files"); ``` ########## seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/ExcelReadStrategy.java: ########## @@ -0,0 +1,191 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.seatunnel.connectors.seatunnel.file.source.reader; + +import org.apache.seatunnel.shade.com.fasterxml.jackson.databind.ObjectMapper; + +import org.apache.seatunnel.api.source.Collector; +import org.apache.seatunnel.api.table.type.SeaTunnelDataType; +import org.apache.seatunnel.api.table.type.SeaTunnelRow; +import org.apache.seatunnel.api.table.type.SeaTunnelRowType; +import org.apache.seatunnel.api.table.type.SqlType; +import org.apache.seatunnel.common.exception.CommonErrorCode; +import org.apache.seatunnel.common.utils.DateTimeUtils; +import org.apache.seatunnel.common.utils.DateUtils; +import org.apache.seatunnel.common.utils.TimeUtils; +import org.apache.seatunnel.connectors.seatunnel.file.config.BaseSourceConfig; +import org.apache.seatunnel.connectors.seatunnel.file.config.HadoopConf; +import org.apache.seatunnel.connectors.seatunnel.file.exception.FileConnectorException; + +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FSDataInputStream; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.poi.ss.usermodel.Cell; +import org.apache.poi.ss.usermodel.CellType; +import org.apache.poi.ss.usermodel.DataFormatter; +import org.apache.poi.ss.usermodel.DateUtil; +import org.apache.poi.ss.usermodel.Row; +import org.apache.poi.ss.usermodel.Sheet; +import org.apache.poi.ss.usermodel.Workbook; +import org.apache.poi.xssf.usermodel.XSSFWorkbook; + +import lombok.SneakyThrows; + +import java.math.BigDecimal; +import java.nio.charset.StandardCharsets; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.time.LocalTime; +import java.time.format.DateTimeFormatter; + +import static org.apache.seatunnel.common.utils.DateTimeUtils.Formatter.YYYY_MM_DD_HH_MM_SS; + +public class ExcelReadStrategy extends AbstractReadStrategy { + + private final DateUtils.Formatter dateFormat = DateUtils.Formatter.YYYY_MM_DD; + + private final DateTimeUtils.Formatter datetimeFormat = YYYY_MM_DD_HH_MM_SS; + private final TimeUtils.Formatter timeFormat = TimeUtils.Formatter.HH_MM_SS; + + @SneakyThrows + @Override + public void read(String path, Collector<SeaTunnelRow> output) { + Configuration conf = getConfiguration(); + FileSystem fs = FileSystem.get(conf); + Path filePath = new Path(path); + FSDataInputStream file = fs.open(filePath); + Workbook workbook = new XSSFWorkbook(file); + Sheet sheet = + pluginConfig.hasPath(BaseSourceConfig.SHEET_NAME.key()) + ? workbook.getSheet( + pluginConfig.getString(BaseSourceConfig.SHEET_NAME.key())) + : workbook.getSheetAt(0); + Row rowTitle = sheet.getRow(0); + int cellCount = rowTitle.getPhysicalNumberOfCells(); + SeaTunnelRow seaTunnelRow = new SeaTunnelRow(cellCount); + SeaTunnelDataType<?>[] fieldTypes = seaTunnelRowType.getFieldTypes(); + int rowCount = sheet.getPhysicalNumberOfRows(); + for (int i = 1; i < rowCount; i++) { + Row rowData = sheet.getRow(i); + if (rowData != null) { + for (int j = 0; j < cellCount; j++) { + Cell cell = rowData.getCell(j); + if (cell != null) { + seaTunnelRow.setField( + j, convert(getCellValue(cell.getCellType(), cell), fieldTypes[j])); + } + } + } + output.collect(seaTunnelRow); Review Comment: Support parse partition field from file path. ########## seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSourceConfig.java: ########## @@ -105,4 +105,10 @@ public class BaseSourceConfig { .listType() .noDefaultValue() .withDescription("The columns list that the user want to read"); + + public static final Option<String> SHEET_NAME = + Options.key("sheet_name") + .stringType() + .noDefaultValue() + .withDescription("To be read sheet name"); Review Comment: The same as above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
