[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #4164: [Feature][ConnectorV2]add file excel sink and source

[via GitHub]

liugddx commented on code in PR #4164:
URL: 
https://github.com/apache/incubator-seatunnel/pull/4164#discussion_r1117858546


##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-local-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/local/LocalFileIT.java:
##########
@@ -53,11 +54,19 @@ public class LocalFileIT extends TestSuiteBase {
                 container.copyFileToContainer(
                         MountableFile.forHostPath(textPath),
                         
"/seatunnel/read/text/name=tyrantlucifer/hobby=coding/e2e.txt");
+                container.copyFileToContainer(
+                        MountableFile.forHostPath(excelPath), 
"/seatunnel/read/excel/e2e.xlsx");
             };
 
     @TestTemplate
     public void testLocalFileReadAndWrite(TestContainer container)
             throws IOException, InterruptedException {
+        Container.ExecResult excelWriteResult =
+                container.executeJob("/excel/fakesource_to_local_excel.conf");
+        Assertions.assertEquals(0, excelWriteResult.getExitCode(), 
excelWriteResult.getStderr());
+        Container.ExecResult excelReadResult =
+                
container.executeJob("/excel/local_excel_sink_to_console.conf");
+        Assertions.assertEquals(0, excelReadResult.getExitCode(), 
excelReadResult.getStderr());

Review Comment:
   Need to check the results.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org