TyrantLucifer commented on code in PR #4164:
URL:
https://github.com/apache/incubator-seatunnel/pull/4164#discussion_r1115299526
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/util/FileSystemUtils.java:
##########
@@ -108,6 +109,12 @@ public FSDataOutputStream getOutputStream(@NonNull String
outFilePath) throws IO
return fileSystem.create(path, true, WRITE_BUFFER_SIZE);
}
+ public FSDataInputStream getInputStream(@NonNull String inFilePath) throws
IOException {
Review Comment:
Why add this method?
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/sink/config/FileSinkConfig.java:
##########
@@ -167,5 +171,13 @@ public FileSinkConfig(@NonNull Config config, @NonNull
SeaTunnelRowType seaTunne
.map(columnsMap::get)
.collect(Collectors.toList());
}
+
+ if (config.hasPath("max_rows_in_memory")) {
Review Comment:
Add Option for these parameters
##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/source/reader/ExcelReadStrategy.java:
##########
@@ -0,0 +1,183 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.connectors.seatunnel.file.source.reader;
+
+import org.apache.seatunnel.shade.com.fasterxml.jackson.databind.ObjectMapper;
+
+import org.apache.seatunnel.api.source.Collector;
+import org.apache.seatunnel.api.table.type.SeaTunnelDataType;
+import org.apache.seatunnel.api.table.type.SeaTunnelRow;
+import org.apache.seatunnel.api.table.type.SeaTunnelRowType;
+import org.apache.seatunnel.api.table.type.SqlType;
+import org.apache.seatunnel.common.exception.CommonErrorCode;
+import org.apache.seatunnel.common.utils.DateTimeUtils;
+import org.apache.seatunnel.common.utils.DateUtils;
+import org.apache.seatunnel.common.utils.TimeUtils;
+import org.apache.seatunnel.connectors.seatunnel.file.config.HadoopConf;
+import
org.apache.seatunnel.connectors.seatunnel.file.exception.FileConnectorException;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.FSDataInputStream;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.Path;
+import org.apache.poi.ss.usermodel.Cell;
+import org.apache.poi.ss.usermodel.CellType;
+import org.apache.poi.ss.usermodel.DataFormatter;
+import org.apache.poi.ss.usermodel.DateUtil;
+import org.apache.poi.ss.usermodel.Row;
+import org.apache.poi.ss.usermodel.Sheet;
+import org.apache.poi.ss.usermodel.Workbook;
+import org.apache.poi.xssf.usermodel.XSSFWorkbook;
+
+import lombok.SneakyThrows;
+
+import java.math.BigDecimal;
+import java.nio.charset.StandardCharsets;
+import java.time.LocalDate;
+import java.time.LocalDateTime;
+import java.time.LocalTime;
+import java.time.format.DateTimeFormatter;
+
+public class ExcelReadStrategy extends AbstractReadStrategy {
+
+ private final DateUtils.Formatter dateFormat =
DateUtils.Formatter.YYYY_MM_DD;
+
+ private final DateTimeUtils.Formatter datetimeFormat =
+ DateTimeUtils.Formatter.YYYY_MM_DD_HH_MM_SS;
+ private final TimeUtils.Formatter timeFormat =
TimeUtils.Formatter.HH_MM_SS;
+
+ @SneakyThrows
+ @Override
+ public void read(String path, Collector<SeaTunnelRow> output) {
+ Configuration conf = getConfiguration();
+ FileSystem fs = FileSystem.get(conf);
+ Path filePath = new Path(path);
+ FSDataInputStream file = fs.open(filePath);
+ Workbook workbook = new XSSFWorkbook(file);
+ Sheet sheet = workbook.getSheetAt(0);
+ Row rowTitle = sheet.getRow(0);
+ int cellCount = rowTitle.getPhysicalNumberOfCells();
+ SeaTunnelRow seaTunnelRow = new SeaTunnelRow(cellCount);
+ SeaTunnelDataType<?>[] fieldTypes = seaTunnelRowType.getFieldTypes();
+ int rowCount = sheet.getPhysicalNumberOfRows();
+ for (int i = 1; i < rowCount; i++) {
+ Row rowData = sheet.getRow(i);
+ if (rowData != null) {
+ for (int j = 0; j < cellCount; j++) {
+ Cell cell = rowData.getCell(j);
+ if (cell != null) {
+ seaTunnelRow.setField(
+ j, convert(getCellValue(cell.getCellType(),
cell), fieldTypes[j]));
+ }
+ }
+ }
+ output.collect(seaTunnelRow);
+ }
+ }
+
+ Configuration getConfiguration() {
+ return getConfiguration(hadoopConf);
+ }
+
+ @Override
+ public SeaTunnelRowType getSeaTunnelRowTypeInfo(HadoopConf hadoopConf,
String path)
+ throws FileConnectorException {
+ throw new FileConnectorException(
+ CommonErrorCode.UNSUPPORTED_OPERATION,
+ "User must defined schema for json file type");
+ }
+
+ private Object getCellValue(CellType cellType, Cell cell) {
+ switch (cellType) {
+ case STRING:
+ return cell.getStringCellValue();
+ case BOOLEAN:
+ return cell.getBooleanCellValue();
+ case NUMERIC:
+ if (DateUtil.isCellDateFormatted(cell)) {
+ DataFormatter formatter = new DataFormatter();
+ return formatter.formatCellValue(cell);
+ }
+ return cell.getNumericCellValue();
+ case ERROR:
+ break;
+ default:
+ throw new FileConnectorException(
+ CommonErrorCode.UNSUPPORTED_DATA_TYPE,
+ String.format("[%s] type not support ", cellType));
+ }
+ return null;
+ }
+
+ @SneakyThrows
+ private Object convert(Object field, SeaTunnelDataType<?> fieldType) {
+ ObjectMapper objectMapper = new ObjectMapper();
+ if (field == null) {
+ return "";
+ }
+ SqlType sqlType = fieldType.getSqlType();
+ switch (sqlType) {
+ case MAP:
+ case ARRAY:
+ return objectMapper.readValue(field.toString(),
fieldType.getTypeClass());
+ case STRING:
+ return field;
+ case BOOLEAN:
+ return Boolean.parseBoolean(field.toString());
+ case FLOAT:
+ return Float.valueOf(field.toString());
+ case DOUBLE:
+ return Double.valueOf(field.toString());
+ case BIGINT:
+ case INT:
+ case TINYINT:
+ case SMALLINT:
+ case DECIMAL:
+ return
BigDecimal.valueOf(Double.parseDouble(field.toString()));
+ case DATE:
+ return DateUtils.toString(LocalDate.parse(field.toString()),
dateFormat);
+ case TIME:
+ return TimeUtils.toString(LocalTime.parse(field.toString()),
timeFormat);
+ case TIMESTAMP:
+ return DateTimeUtils.toString(
+ LocalDateTime.parse(
+ field.toString(),
+ DateTimeFormatter.ofPattern("yyyy-MM-dd
HH:mm:ss")),
+ datetimeFormat);
+ case NULL:
+ return "";
+ case BYTES:
+ String s = field.toString();
+ return s.getBytes(StandardCharsets.UTF_8);
+ case ROW:
+ String delimiter =
pluginConfig.getString("excel_field_delimiter");
Review Comment:
Reuse delimiter of txt file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
