kezhenxu94 commented on a change in pull request #1387:
URL:
https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818822849
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared
here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you
can add it yourself
+ if "mysql-connector-java" in _:
+ continue
Review comment:
> Maybe it would better that you can merge this first and go through
from the begin to understand the whole logic, and then we can discuss more
effectively.
“Merge this first” is not a good practice IMO, codes get merged are rarely
reviewed and re-discussed from my experience, we don’t have a deadline to
deliver something in open source so let’s resolve it first before merging.
The issue here to me is that you unnecessarily deal with the unused
dependencies, because the plugin analyzed them, right?
did you try the option
[`<excludedScopes>`](https://www.mojohaus.org/license-maven-plugin/add-third-party-mojo.html#excludedScopes)
of that plugin to exclude test/provided scope dependencies, this is an
easy-found option that can avoid this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
