CalvinKirs commented on a change in pull request #1387:
URL:
https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818840025
##########
File path: bin/license.py
##########
@@ -102,14 +108,18 @@
"Eclipse Public License": [],
"Public Domain License": [],
"Mozilla Public License Version 2.0": [],
- "Unicode License": [],
+ "Unicode/ICU License": [],
"Go License": [],
"Other License": []
}
for _ in licenses:
+ # Because the license of this project itself dose not need to be declared
here
if "org.apache.seatunnel" in _:
continue
+ # Because the license is not in compliance, if you need to use MySQL, you
can add it yourself
Review comment:
You ignore mysql because the tool detects it, but the real reason is the
above. I mean, if you don't fix it, there will be more unnecessary licenses in
the future. (License compatible but not actually used), but CI is still
successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
