CalvinKirs commented on a change in pull request #1387:
URL:
https://github.com/apache/incubator-seatunnel/pull/1387#discussion_r818771723
##########
File path: seatunnel-dist/release-docs/LICENSE
##########
@@ -220,16 +220,20 @@ The text of each license is the standard Apache 2.0
license.
(APL2) msgpack-core (org.msgpack:msgpack-core:0.9.0 -
https://msgpack.org/)
(Apache 2) Apache Derby Client JDBC Driver
(org.apache.derby:derbyclient:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Database Engine and Embedded JDBC Driver
(org.apache.derby:derby:10.12.1.1 - http://db.apache.org/derby/derby/)
+ (Apache 2) Apache Derby Database Engine and Embedded JDBC Driver
(org.apache.derby:derby:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) Apache Derby Network Server
(org.apache.derby:derbynet:10.14.2.0 - http://db.apache.org/derby/)
(Apache 2) JDO API (javax.jdo:jdo-api:3.0.1 - http://db.apache.org/jdo)
(Apache 2) JavaEWAH (com.googlecode.javaewah:JavaEWAH:0.3.2 -
http://code.google.com/p/javaewah/)
(Apache 2) Joda time (joda-time:joda-time:1.6 -
http://joda-time.sourceforge.net)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.3 -
http://www.joda.org/joda-time/)
+ (Apache 2) Joda-Time (joda-time:joda-time:2.9.9 -
http://www.joda.org/joda-time/)
Review comment:
Usually adding a jar contains multiple dependencies, we are to simplify
the contributor, not to increase the threshold for him. Increasing the
collation is not a good idea, for me it's cumbersome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
