leo65535 edited a comment on pull request #906: URL: https://github.com/apache/incubator-seatunnel/pull/906#issuecomment-1003655792
hi @simon824 @garyelephant thanks for your review. ### Questions > can you briefly explain how to implement the config parsing logic to keep the order as in config file I move all your sort logic to `SeaTunnelConfigParser` which using `LinkedHashMap` to let `transform` in order. _Originally posted by @garyelephant in https://github.com/lightbend/config/issues/365#issuecomment-439778538_ <br> > this version is not very friendly to bump up the version of typesafe config. This is a big changes, so I will split this issue into two sub issues to help finish it, and it's be easier to understand. I will use `maven-shade-plugin` to shade `config` dependency in the next patch, https://github.com/leo65535/seatunnel/tree/config-shade ### Notice After this patch, the keys needs to use double quotation marks in the configuration file, like ``` env { "spark.app.name" = "SeaTunnel" "spark.executor.instances" = 2 "spark.executor.cores" = 1 "spark.executor.memory" = "1g" "spark.streaming.batchDuration" = 5 } sink { "a.b.c.Console" {} } ``` ### Others I add a unit test, we can run it to check whether if the `transforms` are in order or not. ``` org.apache.seatunnel.config.SeaTunnelConfigFactoryTest ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
