[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #906: [SeaTunnel #904] [config] improve the config parse logic

[GitBox]

leo65535 edited a comment on pull request #906:
URL: 
https://github.com/apache/incubator-seatunnel/pull/906#issuecomment-1003287966


   Hi @RickyHuo @garyelephant @CalvinKirs @simon824, I implemented the second 
version, please review the patch when you are free, thanks.
   
   **Tests**
   ```
   org.apache.seatunnel.config.SeaTunnelConfigFactoryTest
   ```
   
   **Changes**
   1. Add `SeaTunnelConfigFactory` which works as `ConfigFactory`.
   2. Extract the sort logic to `SeaTunnelConfigParser`(Keep the logic the same 
as before)
   
   
![image](https://user-images.githubusercontent.com/95013770/147808262-d14bc2fc-cdec-4564-9e71-8c736018c3b2.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org