leo65535 commented on a change in pull request #906:
URL:
https://github.com/apache/incubator-seatunnel/pull/906#discussion_r777172294
##########
File path: tools/checkstyle/checkStyle.xml
##########
@@ -336,13 +336,13 @@
<property name="format"
value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
<message key="name.invalidPattern" value="Class type name ''{0}''
must match pattern ''{1}''."/>
</module>
-
+
<module name="PackageName">
- <property name="format"
value="^org\.apache\.seatunnel(\.[a-zA-Z][a-zA-Z0-9]*)*$"/>
+ <property name="format" value="^[a-z]+(\.[a-z][a-z0-9]{1,})*$"/>
Review comment:
hi @garyelephant,
When we write `SeaTunnelConfigParser`, it will refer to some classes in
`config` project, but these classes don't maked public, so we can only put
`SeaTunnelConfigParser` in `com.typesafe.config.impl` package.
So, we need to chane the checkstyle rule here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
