yyqdbngt opened a new pull request, #3768:
URL: https://github.com/apache/rocketmq-dashboard/pull/3768

   ### Motivation
   
   `ConsumerDiagnosticsServiceTest` already pins the required-field validation 
and the trim-before-delegate behaviour, but two code paths remain unobserved: 
the optional `instanceId` normalisation and whether provider failures survive 
the service untouched.
   
   ### Changes
   
   - `getConsumerStackShouldNormalizeBlankInstanceToNull`: a blank instance id 
is treated as optional and reaches the provider as `null` after both the group 
and client id are trimmed.
   - `getConsumerStackShouldPropagateProviderFailuresUnchanged`: a 
provider-side failure surfaces to the caller with the same exception type and 
message, confirming the service adds no wrapping or swallowing.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=ConsumerDiagnosticsServiceTest
   [INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to