yyqdbngt opened a new pull request, #3766: URL: https://github.com/apache/rocketmq-dashboard/pull/3766
### Motivation The existing `RocketMQBrokerConfigServiceTest` covers update/audit interplay and the flush-disk trim, but the read path that feeds the cluster config page is mostly untested: instance-scoped routing through the runtime resolver, the field-by-field `ClusterConfigVO` mapping, and the fallback behaviour for missing or malformed broker properties. ### Changes - `getBrokerConfigWithInstanceIdDelegatesToRuntimeResolver`: a non-null `instanceId` routes the admin action through `RuntimeAdminClientResolver.execute` instead of the plain name-server factory, and the mapped VO is returned. - `getBrokerConfigMapsEveryPropertyIntoVO`: every broker property (`flushDiskType`, topic-auto-create flags, sizes, queue nums, retention, permission, delete-when, trace topic) lands on the matching `ClusterConfigVO` field. - `getBrokerConfigFallsBackToDefaultsForMissingOrMalformedValues`: an empty property set yields the documented defaults, and non-numeric sizes or an unknown flush mode degrade to their safe fallbacks. ### Verification ``` mvn -B test -Dtest=RocketMQBrokerConfigServiceTest [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 [INFO] BUILD SUCCESS ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
