yyqdbngt opened a new pull request, #3771:
URL: https://github.com/apache/rocketmq-dashboard/pull/3771

   ### Motivation
   
   The existing `AuthCookieTest` verifies the secure cookie flags and the 
bearer-over-cookie precedence, but leaves the logout path, name 
configurability, blank-value skipping and the configurable same-site/secure 
flags unobserved.
   
   ### Changes
   
   - `clearShouldExpireCookieWithZeroMaxAge`: logout writes an empty-value 
cookie with `Max-Age=0`, `HttpOnly` and root path.
   - `ignoresCookiesNotMatchingConfiguredCookieName`: a legacy cookie under the 
default name is ignored once a custom `sessionCookieName` is configured, and a 
cookie under the custom name wins.
   - `skipsBlankCookieValuesWhileScanning`: whitespace-only cookie values are 
skipped while later matching cookies are honoured.
   - `writeShouldHonorConfiguredSameSiteAndInsecureMode`: `SameSite=Lax` and an 
insecure session cookie are reflected verbatim in the emitted header.
   
   ### Verification
   
   ```
   mvn -B test -Dtest=AuthCookieTest
   [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0
   [INFO] BUILD SUCCESS
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to