leizhiyuan commented on PR #7862:
URL: https://github.com/apache/rocketmq/pull/7862#issuecomment-1972969593

   不是的吧,现在要么test tls,要么开启读取tls文件
   
   cserwen ***@***.***> 于 2024年3月1日周五 下午6:52写道:
   
   > ***@***.**** commented on this pull request.
   > ------------------------------
   >
   > In
   > 
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java
   > <https://github.com/apache/rocketmq/pull/7862#discussion_r1508823675>:
   >
   > > @@ -220,10 +227,14 @@ private class TlsModeHandler extends 
ByteToMessageDecoder {
   >          private final ChannelHandler plaintext;
   >
   >          public TlsModeHandler(GrpcHttp2ConnectionHandler grpcHandler) {
   > -            this.ssl = InternalProtocolNegotiators.serverTls(sslContext)
   > +            if (sslContext == null) {
   > +                this.ssl = null;
   >
   > 现在的逻辑应该就是通过 tlsMode 控制的吧,disable 状态 会使用 serverPlaintext() 这个
   > sslContext,好像不需要这个优化
   >
   > —
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/rocketmq/pull/7862#discussion_r1508823675>, or
   > unsubscribe
   > 
<https://github.com/notifications/unsubscribe-auth/AAUPLYDESAEFUEDI6P7IRMDYWBMWHAVCNFSM6AAAAABD3OBX2KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMJQHA3DAMZRHE>
   > .
   > You are receiving this because you were mentioned.Message ID:
   > ***@***.***>
   >
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to