cserwen commented on code in PR #7862:
URL: https://github.com/apache/rocketmq/pull/7862#discussion_r1508823675
##########
proxy/src/main/java/org/apache/rocketmq/proxy/grpc/ProxyAndTlsProtocolNegotiator.java:
##########
@@ -220,10 +227,14 @@ private class TlsModeHandler extends ByteToMessageDecoder
{
private final ChannelHandler plaintext;
public TlsModeHandler(GrpcHttp2ConnectionHandler grpcHandler) {
- this.ssl = InternalProtocolNegotiators.serverTls(sslContext)
+ if (sslContext == null) {
+ this.ssl = null;
Review Comment:
现在的逻辑应该就是通过 tlsMode 控制的吧，disable 状态 会使用 serverPlaintext() 这个
sslContext，好像不需要这个优化
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
