caigy commented on code in PR #197:
URL: https://github.com/apache/rocketmq-operator/pull/197#discussion_r1472774727
##########
deploy/operator.yaml:
##########
@@ -27,7 +27,7 @@ spec:
labels:
name: rocketmq-operator
spec:
- serviceAccountName: rocketmq-operator
+ serviceAccountName: {{ template "rocketmq-operator.serviceAccountName" .
}}
Review Comment:
@sinloss IMO we should fix bugs in `make manifest` to generate correct files
in deploy (for `kubectl`) and charts (for `helm`). Pls check if #212 can
achieve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
