caigy commented on code in PR #197:
URL: https://github.com/apache/rocketmq-operator/pull/197#discussion_r1462633756
##########
deploy/operator.yaml:
##########
@@ -27,7 +27,7 @@ spec:
labels:
name: rocketmq-operator
spec:
- serviceAccountName: rocketmq-operator
+ serviceAccountName: {{ template "rocketmq-operator.serviceAccountName" .
}}
Review Comment:
Files in `deploy` directory are for deploying by `kubectl` instead of helm,
so templating is not supported.
@drivebyer Pls also take a look, it seems some substitution operations
should be added in `make manifest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
