sinloss commented on code in PR #197:
URL: https://github.com/apache/rocketmq-operator/pull/197#discussion_r1471590597
##########
deploy/operator.yaml:
##########
@@ -27,7 +27,7 @@ spec:
labels:
name: rocketmq-operator
spec:
- serviceAccountName: rocketmq-operator
+ serviceAccountName: {{ template "rocketmq-operator.serviceAccountName" .
}}
Review Comment:
Finally got some time for this one. So basically, if I understand it right,
and correct me if I'm not, that those `yaml` files in the `deploy` directory
don't just serve one purpose which is to be copied to the `templates`
directory, they are also being used directly by the `kubectl` command.
And to fix what I want to fix, something needs to be done in the `make
manifest` process to properly *generate / create / substitute after copying /
or any other ways possible* `yaml` files with helm templating contents in the
`templates` directory while at the same time keep `yaml` files in the `deploy`
directory free from helm templating contents.
The thing is, am I allowed to choose whatever means possible to achieve this
or should I wait for some discussions to reach a conclusion and then go on with
this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
