lizhimins commented on code in PR #7492:
URL: https://github.com/apache/rocketmq/pull/7492#discussion_r1408652411
##########
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##########
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+ // support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+ public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
加了这个能热生效吗？通过 rpc update config
##########
common/src/main/java/org/apache/rocketmq/common/ControllerConfig.java:
##########
@@ -209,6 +209,11 @@ public void setMetricsExporterType(MetricsExporterType
metricsExporterType) {
this.metricsExporterType = metricsExporterType;
}
+ // support read from config file using
org.apache.rocketmq.common.MixAll.properties2Object
+ public void setMetricsExporterType(String metricsExporterType) {
Review Comment:
加了这个能热生效吗？通过 rpc update config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
